Add an editor preset for kakoune (kakoune.org).#2577
Merged
jesseduffield merged 1 commit intojesseduffield:masterfrom Apr 29, 2023
Merged
Add an editor preset for kakoune (kakoune.org).#2577jesseduffield merged 1 commit intojesseduffield:masterfrom
jesseduffield merged 1 commit intojesseduffield:masterfrom
Conversation
Contributor
|
Uffizzi Preview |
Collaborator
stefanhaller
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A few questions below.
bd0b43f to
6c010a7
Compare
Contributor
Author
|
Done? :) |
Collaborator
Yes, thanks again. Looks good to me now. I'm not a maintainer here, so I can't merge this, but I'd be surprised if Jesse has anything to complain about. |
Contributor
Author
|
I trust your judgment and I appreciate you for the help. |
Owner
|
Thanks for making this @jbrains ! |
6 tasks
enricozb
reviewed
Jun 5, 2023
| "nvim": standardTerminalEditorPreset("nvim"), | ||
| "emacs": standardTerminalEditorPreset("emacs"), | ||
| "nano": standardTerminalEditorPreset("nano"), | ||
| "kakoune": standardTerminalEditorPreset("kakoune"), |
Contributor
There was a problem hiding this comment.
I think there is an issue with this line. The command for kakoune is kak not kakoune. So it should say:
"kakoune": standardTerminalEditorPreset("kak"),
Collaborator
There was a problem hiding this comment.
Oops, you are right, sorry for missing this. Do you feel like making a trivial PR for this?
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an editor preset for kakoune, so that users can easily configure lazygit to edit files with kakoune.