Skip to content

Pull patch reword commit#2436

Closed
derteta wants to merge 2 commits intojesseduffield:masterfrom
derteta:pull-patch-reword-commit
Closed

Pull patch reword commit#2436
derteta wants to merge 2 commits intojesseduffield:masterfrom
derteta:pull-patch-reword-commit

Conversation

@derteta
Copy link
Contributor

@derteta derteta commented Feb 11, 2023

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2023

Uffizzi Preview Environment deployment-15358

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2436

📄 View Application Logs etc.

What is Uffizzi? Learn more

commitIndex := gui.getPatchCommitIndex()
head_message, _ := gui.git.Commit.GetCommitMessage(gui.State.Model.Commits[commitIndex].FullRefName())

// TODO: use the commit message panel here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably have to wait for this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR is merged now @derteta

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've got a new way of invoking the commit message panel, we can use that in this PR. Lemme know if you need pointers @derteta

@stefanhaller
Copy link
Collaborator

@derteta I took the liberty of opening a new PR that does this using the new commit message panel; hope you don't mind! See #2800.

@jesseduffield
Copy link
Owner

Looks like we can close that off in this case

@derteta
Copy link
Contributor Author

derteta commented Jul 20, 2023

Thanks for taking care of it, @stefanhaller !
I dropped the ball on this one 😞

@jesseduffield
Copy link
Owner

No stress @derteta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants