Merged
Conversation
… the traditional encoding
Submodule integration for piscem
…ter than a random mini
…ter than a random mini: their exp. density is 1.5/(k+0.5); so revert to previous code with a new comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the following changes.
The partitioned_phf type of PTHash is now the default used MPHF, rather than the single_phf which is much faster to build with no slow down at query time nor space overhead.
We now use 128-bit hashes by default, so that we avoid aborting due to the risk of incurring in a hash collision that could be high with 64-bit hashes.
Several minor usability improvements.