Skip to content

feat: update plugin to 5.7 & Jenkins baseline to 2.479.1 #12

Merged
froque merged 2 commits intojenkinsci:masterfrom
biru-codeastromer:pluginupdate
Feb 17, 2025
Merged

feat: update plugin to 5.7 & Jenkins baseline to 2.479.1 #12
froque merged 2 commits intojenkinsci:masterfrom
biru-codeastromer:pluginupdate

Conversation

@biru-codeastromer
Copy link
Copy Markdown
Contributor

@biru-codeastromer biru-codeastromer commented Feb 12, 2025 •
edited
Loading

Description :

  • This PR made the following changes :
  1. Ugraded plugin to 5.7
  2. Upgraded Jenkins baseline to 2.479.1
  3. Upgraded bom version to latest
  4. Updated StaplerRequest to StaplerRequest

Testing done :

  • Testing done through mvn clean verify and mvn clean install

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@biru-codeastromer biru-codeastromer requested a review from a team as a code owner February 12, 2025 16:01
@biru-codeastromer
Copy link
Copy Markdown
Contributor Author

biru-codeastromer commented Feb 12, 2025

Hi @froque , May you please review this and let me know if improvements needed. Thanks !

froque
froque requested changes Feb 17, 2025
View reviewed changes
Comment thread pom.xml Outdated
@biru-codeastromer
Copy link
Copy Markdown
Contributor Author

biru-codeastromer commented Feb 17, 2025

Done !

@froque froque merged commit 65534ae into jenkinsci:master Feb 17, 2025
froque
froque reviewed Feb 17, 2025
View reviewed changes
Comment thread src/main/java/org/jenkinsci/plugins/vb6/VB6Builder.java
* <p>
* When the user configures the project and enables this builder,
* {@link DescriptorImpl#newInstance(StaplerRequest)} is invoked
* {@link DescriptorImpl#newInstance(StaplerRequest2)} is invoked
Copy link
Copy Markdown
Member

@froque froque Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails while building javadoc

@froque froque mentioned this pull request Feb 17, 2025
Merged
@biru-codeastromer biru-codeastromer deleted the pluginupdate branch February 18, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@froque froque froque requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biru-codeastromer @froque