[JENKINS-74917] Fix adjunct script to validate the passphrase when the SSH private key is entered directly#231
Merged
fcojfernandez merged 1 commit intojenkinsci:masterfrom Nov 26, 2024
Conversation
fcojfernandez
commented
Nov 26, 2024
| var newEvent = new Event("change") | ||
| const privateKeyElements = document.getElementsByClassName('sshCredentials_privateKey'); | ||
| if (passphraseElements.length > 0) { | ||
| var newEvent = new Event("change", {"bubbles": true}) |
Member
Author
There was a problem hiding this comment.
this is what allows the event to be dispatched. By default is false
Priya-CB
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this script relies on a secretTextarea having an specific class, but that's not supported in the taglib. Therefore, there was a javascript error preventing the form validations from being updated. The plugin is behaving as expected, and this issue is merely a UX issue.
Note 1: Although this was detected working on FIPS mode, this is not a real FIPS issue
Note 2: This issue is not blocking, the page still works. Simply it's a bit annoying to see that the form validation messages are not updated
Testing done
SSH Username with private keyWith the code in master you'll see an error in the javascript console
With the fix, the javascript error isn't there.
Submitter checklist