Migrate tests to JUnit5#562
Merged
kuisathaverat merged 2 commits intojenkinsci:mainfrom Feb 25, 2025
strangelookingnerd:migrate_to_junit5
Merged
Migrate tests to JUnit5#562kuisathaverat merged 2 commits intojenkinsci:mainfrom strangelookingnerd:migrate_to_junit5
kuisathaverat merged 2 commits intojenkinsci:mainfrom
strangelookingnerd:migrate_to_junit5
Conversation
Contributor
Author
|
On a side-note: Is there any reason the agent tests should not run on windows? They work just fine from what I can tell. |
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Contributor
A long time ago, we ran them on Windows too; they were too flaky in Windows. Due to these, IT verifies several SSH server configurations that work with the SSH build Agents plugins; thus, running them in Windows does not have much value. |
kuisathaverat
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
There is one exception where a migration was not possible as the tests rely on
Ruleimplementations that have not (yet) been migrated to JUnit5:SSHLauncherTestusingDockerRuleI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.