[JENKINS-60902] adds the dependency of the Apache Mina sshd 2.5.1#54
Merged
jglick merged 9 commits intojenkinsci:masterfrom Jun 8, 2021
Merged
[JENKINS-60902] adds the dependency of the Apache Mina sshd 2.5.1#54jglick merged 9 commits intojenkinsci:masterfrom
jglick merged 9 commits intojenkinsci:masterfrom
Conversation
jglick
approved these changes
May 3, 2021
src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
Outdated
Show resolved
Hide resolved
…ase.java Co-authored-by: Jesse Glick <jglick@cloudbees.com>
rsandell
approved these changes
May 18, 2021
kuisathaverat
commented
May 29, 2021
Contributor
Author
|
this plugin does not need the dependency of the sshd-plugin, the Apache Mina SSHD library is only used on tests to create an SSH mock server, so I have replaced the sshd-plugin dependency with a test dependency of the Apache Mina SSHD library on version 2.5.1 |
kuisathaverat
commented
Jun 6, 2021
6 tasks
jglick
approved these changes
Jun 7, 2021
Member
jglick
left a comment
There was a problem hiding this comment.
IIUC this only affects tests? So I can merge but there is no rush on a release?
Contributor
Author
|
no, for this one there is no rush since the dependency is on tests |
jglick
reviewed
Jun 7, 2021
jglick
reviewed
Jun 7, 2021
kuisathaverat
commented
Jun 8, 2021
jglick
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see JENKINS-60902
It adds the dependency of the Apache Mina sshd
It bumps the Apache Mina sshd library to 2.5.1
it bumps core to latest LTS 2.289.1
it replaces jenkinsci/sshd-plugin#33
it depends on JENKINS-55582 jenkinsci/sshd-plugin#46