[JENKINS-65457] Add description to credentials and ignoreMissing argu…#51
Merged
jglick merged 11 commits intojenkinsci:masterfrom Jun 14, 2021
Merged
[JENKINS-65457] Add description to credentials and ignoreMissing argu…#51jglick merged 11 commits intojenkinsci:masterfrom
jglick merged 11 commits intojenkinsci:masterfrom
Conversation
MarkEWaite
suggested changes
Apr 24, 2021
Contributor
MarkEWaite
left a comment
There was a problem hiding this comment.
Clarification on the text for the credentials field
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-credentials.html
Outdated
Show resolved
Hide resolved
…gentStep/help-credentials.html Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
approved these changes
Apr 24, 2021
Contributor
MarkEWaite
left a comment
There was a problem hiding this comment.
Formatting corrections for your consideration. Sorry that I missed them in my earlier review!
Thanks for the pull request!
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-credentials.html
Outdated
Show resolved
Hide resolved
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-credentials.html
Outdated
Show resolved
Hide resolved
…gentStep/help-credentials.html Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
…gentStep/help-credentials.html Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
approved these changes
Apr 24, 2021
Contributor
|
Something that might help reviews is having an image of the steps. I think this looks ok, I just wanted to see the formatting of the help text. |
kwhetstone
reviewed
Apr 26, 2021
Contributor
kwhetstone
left a comment
There was a problem hiding this comment.
Looks good, I like the examples in the help
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-credentials.html
Outdated
Show resolved
Hide resolved
…gentStep/help-credentials.html Co-authored-by: Kristin Whetstone <kwhetstone@cloudbees.com>
oleg-nenashev
approved these changes
Apr 26, 2021
Member
oleg-nenashev
left a comment
There was a problem hiding this comment.
Just a few minor suggestions
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-ignoreMissing.html
Outdated
Show resolved
Hide resolved
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-ignoreMissing.html
Outdated
Show resolved
Hide resolved
…gentStep/help-ignoreMissing.html Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
…gentStep/help-ignoreMissing.html Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
MRamonLeon
approved these changes
Apr 28, 2021
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-credentials.html
Outdated
Show resolved
Hide resolved
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-ignoreMissing.html
Outdated
Show resolved
Hide resolved
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-ignoreMissing.html
Outdated
Show resolved
Hide resolved
src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help-ignoreMissing.html
Outdated
Show resolved
Hide resolved
…gentStep/help-credentials.html Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
…gentStep/help-ignoreMissing.html Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
…gentStep/help-ignoreMissing.html Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
…gentStep/help-ignoreMissing.html Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ments
help-credentials.htmlfile to addcredentialsargument description.help-ignoreMissing.htmlfile to addignoreMissingargument description.@MarkEWaite @oleg-nenashev @kwhetstone @StackScribe @aHenryJard