New implementation of ssh-agent (second attempt)#17
Merged
jglick merged 9 commits intojenkinsci:masterfrom Feb 10, 2017
Merged
Conversation
…stalled on a slave. Not working yet with keys protected by a passphrase.
OpenSSH 7.0 and greater disables use of ssh-dss public key algorithm. To allow tests to run on system with OpenSSH 7.0, explicitly enable ssh-dss by passing `-o HostKeyAlgorithms=+ssh-dss`.
|
It seems the test don't like the new ssh flag: |
Contributor
Author
|
Yeah, it does not. The question is how to solve this problem. I would have hoped CLI interface o older (open)ssh would remain compatible. Apparently not. So I need to hack tests again and only include the option iff client is >= 7.0. Sigh. There's another problem though - sshAgentAvailableAfterRestart is broken. This also needs further investigation... |
Older OpenSSH implementations does not support the `...=+ssh-dss` syntax to add a key alg (mind the `+`), So use `...=ssh-dss` to make tests working also on pre-7.0 versions of OpenSSH. This is an amendment of commit 66bae3b.
4 tasks
Member
Fixed that in #18 and am working on other cleanup and testing. |
Contributor
Author
|
@jglick: Thank you so much for finishing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt to provide an alternative implementation of SSH agent by using
(remote) hosts native
ssh-agent.It's a resurrection of earlier attempt made by @Mi-La some time ago - see PR2. The changes are following:
Launcherinterface to check whetherssh-agentis installed.