Fix issue where Selenium admin permission wasn't honored in UI #107
Merged
rouke-broersma merged 1 commit intojenkinsci:masterfrom Sep 3, 2017
Merged
Fix issue where Selenium admin permission wasn't honored in UI #107rouke-broersma merged 1 commit intojenkinsci:masterfrom
rouke-broersma merged 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jelly files were using the isAdmin from the built-in Hudson object instead of the one defined in the PluginImpl. That means the Selenium Admin permission wasn't being honored correctly.
See https://issues.jenkins-ci.org/browse/JENKINS-31260 for an example of the issue