[JENKINS-71515] Make codemirror-config a valid JSON#26
Merged
froque merged 1 commit intojenkinsci:masterfrom Sep 5, 2023
Merged
[JENKINS-71515] Make codemirror-config a valid JSON#26froque merged 1 commit intojenkinsci:masterfrom
codemirror-config a valid JSON#26froque merged 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed before jenkinsci/jenkins#6867 can get merged.
codemirror-configattribute is expected to be a valid JSON except the start and end bracket as per https://github.com/jenkinsci/jenkins/blob/cd3b1517e7a553fd6fcf39e25c4bd1e18fbe39de/core/src/main/resources/lib/form/textarea.jelly#L70-L73.In the upstream change
JSON#parseis used instead ofevalto transform thecodemirror-configinto a JSON object.JSON#parsecannot parse function attributes, hence the drop ofonBlurhandler in this PR. There seems to be no need for it because this code re-adds it.Testing done
Tested interactively against jenkinsci/jenkins#6867. Created a freestyle job, added the PowerShell build step. Made sure
codemirror-configis parsed correctly, and no errors are thrown in the developer console.