Removes force insertion of '$ErrorActionPreference = "Continue"' if "Stop On Errors" is unchecked#21
Merged
froque merged 2 commits intojenkinsci:masterfrom Dec 23, 2022
Conversation
added 2 commits
December 12, 2022 14:27
…orActionPreference if stopOnError is false
Author
|
@froque Is there any additional information I need to provide for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the intent of #18 to fix the behavior shown in https://issues.jenkins.io/browse/JENKINS-60423, undo the breaking change introduced in version 1.4 where it will force insert the line
$ErrorActionPreference = "Continue"if the "Stop On Errors" checkbox is enabled, as this breaks the usage of PowerShell scriptblocks that have advanced parameter blocks at the beginning that contain[CmdletBinding()]and/orparam()blocks since these must be the first executable line within a scriptblock if given.However, this differs from #18 where instead of moving to a choice between
Stop,Continue, or no insertion at all, this branch instead just removes the insertion if the option is unchecked, as the default behavior of PowerShell's$ErrorActionPreferenceisContinue.tl;dr - Keep the plugin interface and intended behavior the same, but remove the breaking behavior of forcing
$ErrorActionPreference = "Continue"into the beginning of the script since this is a default setting