Rely on data-binding to (re)configure descriptor by ndeloof · Pull Request #39 · jenkinsci/mailer-plugin

ndeloof · 2017-11-23T13:41:48Z

rely on @DataBoundSetter annotations for data-binding with the global.jelly web-UI.
prefer a nested databound component vs a boolean pseudo-property (useSMTPAuth)

as Descriptor is re-configured, and not created from scratch by data-binding, need to reset attributes to default values.

Those changes are required by jenkinsci/configuration-as-code-plugin#2

jglick · 2018-01-08T20:01:41Z

src/main/resources/hudson/tasks/Mailer/help-authentication_zh_CN.html

-<div>
-  当发送邮件时使用SMTP认证.如果你的环境需要使用SMTP认证,在这里指定其用户名和密码.
+<div>
+  当发送邮件时使用SMTP认证.如果你的环境需要使用SMTP认证,在这里指定其用户名和密码.


Do I dare ask?

Not sure. local git tool only reports file being moved, no internal changes.

jglick · 2018-01-08T20:02:26Z

src/main/java/hudson/tasks/SMTPAuthentication.java

+    private Secret smtpAuthPassword;
+
+    @DataBoundConstructor
+    public SMTPAuthentication(String smtpAuthUsername, Secret smtpAuthPassword) {


The smtpAuth prefix on these property names is redundant. Better to switch to just username & password.

jglick · 2018-01-08T20:05:02Z

src/main/resources/hudson/tasks/SMTPAuthentication/config_de.properties

+
+Use\ SMTP\ Authentication=Verwende SMTP Authentifizierung
+User\ Name=Benutzername
+Password=Kennwort


I think you neglected to remove these keys from Mailer/global_*.properties.

jenkinsci/jenkins/core/move-l10n.groovy is a useful tool that could perhaps be converted to a mojo in org.jvnet.localizer:maven-localizer-plugin.

I indeed didn't know about this script (and others).

AndreaGiardini · 2018-05-24T15:32:26Z

@jglick Hi! Can we push this pull-request forward? It is really necessary in order to use configuration-as-code with the mailer plugin, and since this plugin is very popular it would be nice to have it :)

Thank you

AndreaGiardini · 2018-06-22T12:55:47Z

@jglick @ndeloof @kohsuke Sorry to bother you again, can somebody review this pull request? :)

canhanhan · 2018-09-25T21:02:13Z

This caused issues with the send test e-mail feature. It was failing at form validation due to field names being different. I sent a PR to the source fork: https://github.com/ndeloof/mailer-plugin/pull/1

gomesp · 2018-10-20T10:34:06Z

It seems that the upstream PR has been merged. Does it mean that the example at https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/demos/mailer now works (or do we still need this PR to be merged as well)?

QuentinBisson · 2018-10-22T16:43:46Z

@jglick @ndeloof @kohsuke Sorry to bother you about this. Any news on when it's gonna be merged ? I need the possibility to add authentication from configuration as code plugin

oleg-nenashev · 2018-10-22T20:35:31Z

I have no bandwidth to review it this week. Everybody is busy at Jenkins World, I believe

…witch to just username & password.

…tication

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

darxriggs · 2019-02-10T10:43:21Z

ping

alecharp

@jglick I was looking at this PR and wondering how the data migration to the SMTPAuthentication is done. I'll test it locally by wondering if you could confirm that it's what the lines https://github.com/jenkinsci/mailer-plugin/pull/39/files#diff-e64d5e9d7b997b028696a748431563ceR387 are about. Thanks

jglick · 2019-03-01T21:58:39Z

I am afraid I have no memory of this PR. Needs a maintainer.

przecze · 2019-03-06T13:57:37Z

As mentioned before, I'm also looking forward to this PR being merged, so I can use JCasC for mailer.

darxriggs · 2019-03-10T09:57:25Z

src/main/resources/hudson/tasks/SMTPAuthentication/config_zh_CN.properties

+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+


@ndeloof Why does this properties file contain 13 properties whereas the other ones only contain 3?

darxriggs · 2019-03-10T10:01:06Z

src/main/resources/hudson/tasks/Mailer/global_fr.properties

@@ -30,8 +30,5 @@ Default\ user\ e-mail\ suffix=Suffixe par d\u00E9faut des emails des utilisateur
 Sender\ E-mail\ Address=Adresse e-mail de l''''exp\u00E9diteur


In l''''exp\u00E9diteur there are two extra '' which should be removed.

darxriggs · 2019-03-10T10:07:02Z

src/main/resources/hudson/tasks/Mailer/global.properties

@@ -0,0 +1,22 @@
+# The MIT License


@ndeloof Why is this empty "global.properties" file added for Mailer but no "config.properties" for SMTPAuthentication?

darxriggs · 2019-03-10T10:08:03Z

src/main/resources/hudson/tasks/SMTPAuthentication/config.jelly

+
+<?jelly escape-by-default='true'?>
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
+      <f:entry title="${%User Name}" field="username">


@ndeloof Indentation (lines 27-32) should be corrected from 6 to 2.

darxriggs · 2019-03-10T10:12:20Z

src/main/resources/hudson/tasks/Mailer/global_es.properties

 # THE SOFTWARE.

-E-mail\ Notification=Notificaci�n por correo electr�nico
+E-mail\ Notification=Notificaci�n por correo electr�nico


@ndeloof Just looking at the diff on GitHub it looks like the encoding got broken. Could you double-check this (this and other properties files)?

darxriggs · 2019-03-10T10:14:49Z

src/main/resources/hudson/tasks/Mailer/global_da.properties

 Default\ user\ e-mail\ suffix=Standard e-mail endelse
 Use\ SSL=Brug SSL
 SMTP\ Port=SMTP Port
-Use\ SMTP\ Authentication=Benyt SMTP Authentificering


@ndeloof Did you miss to remove Password in line 23?

darxriggs · 2019-03-10T10:19:08Z

src/main/resources/hudson/tasks/Mailer/global_da.properties

 Default\ user\ e-mail\ suffix=Standard e-mail endelse
 Use\ SSL=Brug SSL
 SMTP\ Port=SMTP Port
-Use\ SMTP\ Authentication=Benyt SMTP Authentificering


@ndeloof "${%Use SMTP Authentication}" is still used in "Mailer/global.jelly".
Is it correct to move it from "Mailer/global*.properties" to "SMTPAuthentication/config*.properties"?

darxriggs · 2019-03-22T20:35:38Z

@ndeloof ping

jglick · 2019-04-03T01:07:03Z

I do not think @ndeloof is working on this any more. Would fall to whoever is driving configuration-as-code these days. CC @ewelinawilkosz

darxriggs · 2019-04-14T18:51:54Z

@alecharp do you still have this on your list as mentioned in the Jira issue?

alecharp · 2019-04-14T18:54:02Z

Yes I am, sorry I didn't take the time before. Will certainly take it in the next few days to review and or complete. Le dim. 14 avr. 2019 à 20:51, René Scheibe <notifications@github.com> a écrit :

…

@alecharp <https://github.com/alecharp> do you still have this on your list as mentioned in the Jira issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8LYzj0N9fz3Av24YISNv_26eo0OAEEks5vg3jPgaJpZM4QoxOQ> .

darxriggs · 2019-04-14T19:16:14Z

Thank you very much in advance.

bobbui · 2019-06-27T01:17:43Z

any update guys?

pietroaragona · 2019-07-19T08:00:30Z

Any news about this PR? It is very useful when use JCAC plugin
Thanks

h1dden-da3m0n · 2019-08-05T07:29:48Z

Okay, sorry to make this note here but I believe it will help a few people that find this PR based on the JCasC demos, which state setting SMTP doesn't work.
It dose now, or better since the mailer plugin version 1.22 issue, pr).
I'll try and get a PR in with the JCasC demos to fix the statement that it doesn't work.

NOTE: I do not claim to be familiar with this PR or what it intends to change/fix so it might still be useful/necessary to fix other issues. I only posted this here since I got redirected here and just by accident found out that setting SMTP already works now and thought other people might have that same "problem".

bobbui · 2019-08-05T07:32:50Z

Okay, sorry to make this note here but I believe it will help a few people that find this PR based on the JCasC demos, which state setting SMTP doesn't work.
It dose now, or better since the mailer plugin version 1.22 issue, pr).
I'll try and get a PR in with the JCasC demos to fix the statement that it doesn't work.

NOTE: I do not claim to be familiar with this PR or what it intends to change/fix so it might still be useful/necessary to fix other issues. I only posted this here since I got redirected here and just by accident found out that setting SMTP already works now and thought other people might have that same "problem".

awesome, looking forward to it.
thanks

fcojfernandez · 2019-08-26T15:50:57Z

Superseded by #61 which intends to land this PR, which seems to be stalled and with no progress. That PR also fixes the test failure in the PR-builder and adds tests to check the compatibility with JCasC.

@alecharp you can close this PR as your convenience.

ndeloof requested review from jglick and kohsuke December 12, 2017 20:50

ndeloof mentioned this pull request Dec 16, 2017

Accepting JEP #201 as BDFL jenkinsci/jep#40

Merged

jglick reviewed Jan 8, 2018

View reviewed changes

oleg-nenashev mentioned this pull request Sep 8, 2018

Mailer: fix missing getter for smtpHost property #42

Merged

ndeloof mentioned this pull request Sep 10, 2018

What happened to unclassified->mailer->smtpHost? jenkinsci/configuration-as-code-plugin#503

Closed

ndeloof closed this Sep 10, 2018

ndeloof reopened this Sep 10, 2018

ndeloof added 8 commits November 27, 2018 13:55

migrate optional block to optional databound property

ef7888a

deprecation notice

dfbea56

reset attributes to default values before applying data-binding

19e400c

use @deprecated so we can programmatically exclude those properties

a064272

The smtpAuth prefix on these property names is redundant. Better to s…

0850edb

…witch to just username & password.

remove keys from Mailer/global_*.properties being moved to SMTPAuthen…

cdd3f2b

…tication

fix failing test case

0324824

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

use BulkChange

1903d21

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

alecharp self-requested a review December 3, 2018 08:50

alecharp reviewed Feb 12, 2019

View reviewed changes

darxriggs reviewed Mar 10, 2019

View reviewed changes

h1dden-da3m0n mentioned this pull request Aug 5, 2019

Update mailer-plugin demo jenkinsci/configuration-as-code-plugin#971

Merged

5 tasks

fcojfernandez mentioned this pull request Aug 26, 2019

[JENKINS-55109] JCasC compatibility #61

Merged

alecharp merged commit 1903d21 into jenkinsci:master Aug 30, 2019

		@@ -30,8 +30,5 @@ Default\ user\ e-mail\ suffix=Suffixe par d\u00E9faut des emails des utilisateur
		Sender\ E-mail\ Address=Adresse e-mail de l''''exp\u00E9diteur

Uh oh!

Conversation

ndeloof commented Nov 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreaGiardini commented May 24, 2018

Uh oh!

AndreaGiardini commented Jun 22, 2018

Uh oh!

canhanhan commented Sep 25, 2018

Uh oh!

gomesp commented Oct 20, 2018

Uh oh!

QuentinBisson commented Oct 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleg-nenashev commented Oct 22, 2018

Uh oh!

darxriggs commented Feb 10, 2019

Uh oh!

alecharp left a comment

Choose a reason for hiding this comment

Uh oh!

jglick commented Mar 1, 2019

Uh oh!

przecze commented Mar 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darxriggs Mar 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darxriggs commented Mar 22, 2019

Uh oh!

jglick commented Apr 3, 2019

Uh oh!

darxriggs commented Apr 14, 2019

Uh oh!

alecharp commented Apr 14, 2019 via email

Uh oh!

darxriggs commented Apr 14, 2019

Uh oh!

bobbui commented Jun 27, 2019

Uh oh!

pietroaragona commented Jul 19, 2019

Uh oh!

h1dden-da3m0n commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobbui commented Aug 5, 2019

Uh oh!

fcojfernandez commented Aug 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

QuentinBisson commented Oct 22, 2018 •

edited

Loading

darxriggs Mar 10, 2019 •

edited

Loading

h1dden-da3m0n commented Aug 5, 2019 •

edited

Loading