Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

In order to fix jenkinsci/custom-folder-icon-plugin#93 I went over most of the icons and added missing fill="currentColor" attributes if they were missing. I might have become snow-blind doing this so sorry if I missed something.

Here is a preview of the icons in white and dark theme:

image
image

I was unsure whether to create this PR here or directly in https://github.com/ionic-team/ionicons - let me know what works best for you.

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner October 5, 2022 13:40
@timja
Copy link
Member

timja commented Oct 5, 2022

I was unsure whether to create this PR here or directly in ionic-team/ionicons - let me know what works best for you.

Ideally both, they haven't been very responsive to pull requests though, but would be good to at least submit it there.

Thanks for the change!

@timja timja added the enhancement New feature or request label Oct 5, 2022
@timja timja merged commit 0a57384 into jenkinsci:main Oct 5, 2022
@NotMyFault
Copy link
Member

Ideally both, they haven't been very responsive to pull requests though, but would be good to at least submit it there.

Historically, I submitted all fixes to ionicons we addressed in core, but none of them received feedback by now, that would allow us to get further with it.

I'm fine with fixing issues here, and potentially adding more symbols 👍🏻

@timja
Copy link
Member

timja commented Oct 5, 2022

I'm fine with fixing issues here, and potentially adding more symbols 👍🏻

I'm unsure about new ones being in here, if we want some custom specific ones they should go in the plugin related to them.
If they're reusable there could be a shared one.

@NotMyFault
Copy link
Member

if we want some custom specific ones they should go in the plugin related to them

Agreed. The Jenkins icon I added is a general purpose symbol, but generally I don't think we need to add any symbol, unless they directly relate to this project.

@NotMyFault NotMyFault added bug Something isn't working and removed enhancement New feature or request labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong ionicon color with dark-theme

3 participants