fix commit status ref on tag push event #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dd55b1 to
26f01c2
Compare
Member
|
Thanks very much for this fix! I'll try to get it merged shortly. |
Member
|
@ScienJus I have introduced some merge conflicts here. Can you resolve them? |
26f01c2 to
bff630b
Compare
Contributor
Author
|
@omehegan The conflicts resolved, let's wait for travels ci to complete. |
Member
|
@ScienJus awesome, thanks for the quick response!! |
Member
|
Released in version 1.5.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #677 .
When a tag push event is received,
updateGitlabCommitStatuswill use the tag name instead of the branch name to ensure consistency with gitlab ci.