Make Secret Token updates work when CSP is enforced #1840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1837 by no longer depending on the undocumented
f:validateButtonfeature. I recommend squash-merging due to unclean PR commit history.As a bonus, made the form field ID a little more unique, in case there'd be some other plugin with a
secretTokenfield.Testing done
Clicked the buttons in a freestyle config, see #1837. Saving still works, new value is effective on page load.
With CSP plugin installed, no new CSP findings in Manage Jenkins » Content Security Policy Report.
Screenshots
Before
After
Submitter checklist