Skip to content

Conversation

@MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 3, 2025

Replace deprecated SNAKE_CASE with current SNAKE_CASE

Jackson API 2.20.0 removes the PropertyNamingStrategy.SNAKE_CASE symbol. The replacement symbol is PropertyNamingStrategies.SNAKE_CASE.

Refer to BOM test failures in:

Testing done

Confirmed that previous code fails to compile with Jackson 2 API 2.20.0 incremental build.

Confirmed it compiles with Jackson 2 API 2.20.0 incremental build and with current Jackson 2 API 2.19.x.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Sep 3, 2025
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 3, 2025 02:55
Jackson API 2.20.0 removes the PropertyNamingStrategy.SNAKE_CASE symbol.
The replacement symbol is PropertyNamingStrategies.SNAKE_CASE.

Refer to BOM test failures in:

* jenkinsci/bom#5622

Testing done:

Confirmed it compiles with Jackson 2 API 2.20.0 incremental build and
with current Jackson 2 API 2.19.x.
@MarkEWaite MarkEWaite force-pushed the prepare-for-jackson-2.20.0 branch from 66e480d to 759758e Compare September 3, 2025 02:57
@MarkEWaite
Copy link
Contributor Author

@krisstern this needs to be merged and released before the Jackson 2 API plugin is updated to 2.20.0, otherwise users may see an exception reported when using the plugin.

@MarkEWaite MarkEWaite changed the title Replace deprecated SNAKE_CASE with current SNAKE_CASE Resolve incompatibility with Jackson 2 API 2.20.0 Sep 3, 2025
@basil basil mentioned this pull request Sep 5, 2025
@krisstern
Copy link
Member

Thanks @MarkEWaite let me handle this now

@krisstern krisstern merged commit 5f7d20c into jenkinsci:master Sep 6, 2025
18 checks passed
@krisstern
Copy link
Member

@MarkEWaite
Copy link
Contributor Author

@MarkEWaite a new release 1.9.9 has just been cut: https://github.com/jenkinsci/gitlab-plugin/releases/tag/gitlab-plugin-1.9.9

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants