Skip to content

Migrate tests to JUnit5 #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krisstern merged 2 commits into from
Apr 18, 2025
Merged

Migrate tests to JUnit5 #1762

krisstern merged 2 commits into from
Apr 18, 2025

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Apr 11, 2025 •
edited by krisstern
Loading

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd
Migrate tests to JUnit5
314810d 
* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner April 11, 2025 08:23
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests This PR adds/removes/updates test cases labels Apr 11, 2025
strangelookingnerd
strangelookingnerd commented Apr 11, 2025
View reviewed changes
src/test/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStepTest.java
Copy link
Contributor Author

@strangelookingnerd strangelookingnerd Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was not migrated as it is using RealJenkinsRule for which there is no JUnit5 equivalent.

Copy link
Member

@krisstern krisstern Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes, thanks for letting us know!

@krisstern
Copy link
Member

krisstern commented Apr 11, 2025

Thanks @strangelookingnerd for the pull request! Yes, we are interested in having the JUnit tests migrated to JUnit 5. I will review this PR shortly.

krisstern
krisstern approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern merged commit 34aa443 into jenkinsci:master Apr 18, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch April 18, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krisstern krisstern krisstern approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file tests This PR adds/removes/updates test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strangelookingnerd @krisstern