Skip to content

Support withCredentials on GitLabApiToken(Impl) #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krisstern merged 7 commits into from
Apr 7, 2025
Merged

Support withCredentials on GitLabApiToken(Impl) #1754

krisstern merged 7 commits into from
Apr 7, 2025

Conversation

@tiago-teixeira5
Copy link
Contributor

@tiago-teixeira5 tiago-teixeira5 commented Mar 21, 2025 •
edited by krisstern
Loading

Fixes #536

Inspired #878 , turns out it was missing the MultiBinding implementation for the GitLabApiTokenImpl class GitLabApiToken interface.

During tests (mvn verify), there was an unexpected failure on GitLabConnectionConfigTest due to my machine having port 80 being listened to. Changing the port to an uncommon port (47 is reserved but apparently not assigned) allowed to circumvent that.

Testing done

A test was added that runs the full pipeline for testing withCredentials, binding with both the full $class and the gitlabApiToken name.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@tiago-teixeira5 tiago-teixeira5 requested a review from a team as a code owner March 21, 2025 07:52
@github-actions github-actions bot added the tests This PR adds/removes/updates test cases label Mar 21, 2025
@tiago-teixeira5 tiago-teixeira5 force-pushed the feature/withCredentials branch from 67704f7 to 3f23564 Compare March 24, 2025 15:06
@krisstern
Copy link
Member

krisstern commented Mar 24, 2025

Thanks @tiago-teixeira5! I will give this a review over the next few days

@tiago-teixeira5 @krisstern
revert test port back to 80
c3ad6d6 
Co-authored-by: Kris Stern <krisstern@outlook.com>
krisstern
krisstern approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tiago-teixeira5 for the PR!
LGTM

@krisstern krisstern merged commit 4f72825 into jenkinsci:master Apr 7, 2025
17 checks passed
@krisstern krisstern added the enhancement For changelog: Minor enhancement. Use 'major-rfe' for changes to be highlighted label Apr 10, 2025
@neyrick neyrick mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krisstern krisstern krisstern approved these changes

Assignees

No one assigned

Labels

enhancement For changelog: Minor enhancement. Use 'major-rfe' for changes to be highlighted tests This PR adds/removes/updates test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

withCredentials in pipeline not supported

2 participants

@tiago-teixeira5 @krisstern