Skip to content

Filter out duplicate builds correctly#48

Merged
bluesliverx merged 3 commits intojenkinsci:masterfrom
flowlogix:dedup-builds
Sep 14, 2022
Merged

Filter out duplicate builds correctly#48
bluesliverx merged 3 commits intojenkinsci:masterfrom
flowlogix:dedup-builds

Conversation

@lprimak
Copy link
Contributor

@lprimak lprimak commented Sep 9, 2022 •
edited
Loading

Prevents submission of duplicate jobs by comparing them to the ones already submitted.
Fixes the underlying issues while not preventing multiple jobs per action from running

  • please use "ignore whitespace" when reviewing *

fixes #27
fixes #32
fixes #49

  • [X ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ X] Ensure that the pull request title represents the desired changelog entry
  • [X ] Please describe what you did
  • [X ] Link to relevant issues in GitHub or Jira
  • [X ] Link to relevant pull requests, esp. upstream and downstream changes
  • [X ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lprimak lprimak marked this pull request as ready for review September 9, 2022 03:13
@lprimak lprimak changed the title Dedup builds Filter out duplicate builds Sep 9, 2022
@lprimak lprimak changed the title Filter out duplicate builds Filter out duplicate builds correctly Sep 9, 2022
@lprimak lprimak mentioned this pull request Sep 9, 2022
Closed
6 tasks
@lprimak
Copy link
Contributor Author

lprimak commented Sep 14, 2022

@bluesliverx What do you think?

@lprimak lprimak mentioned this pull request Sep 14, 2022
Closed
@bluesliverx
Copy link
Contributor

bluesliverx commented Sep 14, 2022

Sorry @lprimak, finally looked at this. This solution looks great! My only concern that the job instances may not be exactly equal depending on how they are constructed/stored. The worst that can happen here is that we get duplicate triggers for the same job, however, and you should be able to tell if that is happening or not pretty quickly I think.

I'll get this merged and released, thanks for contributing again!

@bluesliverx bluesliverx merged commit 986d787 into jenkinsci:master Sep 14, 2022
@lprimak lprimak deleted the dedup-builds branch September 14, 2022 20:07
@lprimak
Copy link
Contributor Author

lprimak commented Sep 15, 2022

Thank you! I have been running with this version for a while and haven't seen any duplicate commits.
They used to happen to me all the time, so it should work for most cases :)

@bluesliverx
Copy link
Contributor

bluesliverx commented Sep 15, 2022

This has now been released. Thanks again!

@vijayreddy579 vijayreddy579 mentioned this pull request Dec 14, 2022
Closed
@sparrowt sparrowt mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trigger more than one job with single PR comment This plugin triggers the build twice Job is triggered twice with this plugin

2 participants

@lprimak @bluesliverx