Skip to content

Migrate tests to JUnit Jupiter#387

Merged
KostyaSha merged 7 commits intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5
Nov 17, 2025
Merged

Migrate tests to JUnit Jupiter#387
KostyaSha merged 7 commits intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Jan 23, 2025 •
edited
Loading

This PR aims to migrate all tests to JUnit Jupiter. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Migrate GHMock from Rule to Extension
  • Migrate DataProviderRunner to ParameterizedTest
  • Remove public visibility for test classes and methods
  • Minor clean up
  • Ban JUnit4 imports

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@KostyaSha
Copy link
Member

KostyaSha commented Jan 23, 2025

for which there is no JUnit5 equivalent

That's why junit5 was not used. What is the goal at all of doing this?

@strangelookingnerd
Copy link
Contributor Author

strangelookingnerd commented Jan 24, 2025

That's why junit5 was not used.

As I wrote its not available yet, but will be once jenkinsci/jenkins-test-harness#900 is being delivered via a newer plugin-pom version.

What is the goal at all of doing this?

In general I'd say it's a good practice to not rely on outdated libraries - even for testing. This PR removes one of these outdated libraries (com.tngtech.java:junit-dataprovider) entirely and updates another one to a more recent and therefore supported and maintained version (com.github.tomakehurst:wiremock-jre8-standalone).
Upgrading from JUnit4 to 5 not only brings some advantages in usage and features but also makes the test implementations not depend on a framework version that is no longer maintained.

@strangelookingnerd strangelookingnerd marked this pull request as ready for review January 27, 2025 19:52
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 27, 2025 19:52
strangelookingnerd and others added 5 commits February 20, 2025 15:02
@strangelookingnerd
Migrate tests to JUnit5
e6bd25b 
* Migrate annotations and imports
* Migrate assertions
* Migrate GHMock Rule to Extension
* Migrate to DataProviderRunner to ParameterizedTest
* Remove public visibility for test classes and methods
* Minor clean up
@strangelookingnerd
Merge branch 'master' into migrate_to_junit5
92b793a
@strangelookingnerd
Merge branch 'master' into migrate_to_junit5
c4be473
@strangelookingnerd
Merge branch 'master' into migrate_to_junit5
345a0b5
@strangelookingnerd
Merge branch 'master' into migrate_to_junit5
2b6f466
@strangelookingnerd
Copy link
Contributor Author

strangelookingnerd commented Jul 21, 2025

@jenkinsci/github-plugin-developers Kindly requesting a review.

@strangelookingnerd
Merge branch 'master' into migrate_to_junit5
d578ead 
# Conflicts:
#	src/test/java/com/cloudbees/jenkins/GlobalConfigSubmitTest.java
@strangelookingnerd strangelookingnerd changed the title Migrate tests to JUnit5 Migrate tests to JUnit Jupiter Nov 14, 2025
@strangelookingnerd
Migrate tests to JUnit Jupiter
389ec1b 
* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
* Ban JUnit4 imports
@KostyaSha
Copy link
Member

KostyaSha commented Nov 17, 2025

just merge it?

@strangelookingnerd
Copy link
Contributor Author

strangelookingnerd commented Nov 17, 2025

just merge it?

No objections from my end. Since tests pass, coverage is the same and no other check is failing it's pretty safe to assume the migration is successful. I will anyway stick around and am happy to take care of any issues that may result out of merging.

@KostyaSha KostyaSha merged commit 4127935 into jenkinsci:master Nov 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strangelookingnerd @KostyaSha