Skip to content

JENKINS-72788: Un-inlining JS in GitHubPushTrigger/config.groovy#383

Merged
KostyaSha merged 1 commit intojenkinsci:masterfrom
krystaltt:Un-inliningJS
Jul 25, 2024
Merged

JENKINS-72788: Un-inlining JS in GitHubPushTrigger/config.groovy#383
KostyaSha merged 1 commit intojenkinsci:masterfrom
krystaltt:Un-inliningJS

Conversation

@krystaltt
Copy link
Contributor

See JENKINS-72788.

Testing done

After un-inlining the inline javascript in GitHubPushTrigger/config.groovy, it still can periodically send request to the "checkHookRegistered" endpoint.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@KostyaSha KostyaSha merged commit 56810df into jenkinsci:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants