Skip to content

[JENKINS-73163] Follow up on Overall/Manage permission support#379

Merged
KostyaSha merged 2 commits intojenkinsci:masterfrom
amuniz:JENKINS-73163
May 13, 2024
Merged

[JENKINS-73163] Follow up on Overall/Manage permission support#379
KostyaSha merged 2 commits intojenkinsci:masterfrom
amuniz:JENKINS-73163

Conversation

@amuniz
Copy link
Member

@amuniz amuniz commented May 13, 2024

In #378 some features were left out, but I see now that they are all part of the same global configuration section. So it does not make sense
to leave them behind. They all require Overall/Manage now (instead of Administer).

I've manually tested that all the configuration is shown in the UI for a user with Overall/Manage.

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

amuniz added 2 commits May 13, 2024 14:11
In jenkinsci#378 some features were left out, but I see now that they are all
part of the same global configuration section. So it does not make sense
to leave them behind. They all require Overall/Manage now (instead of
Administer).
@KostyaSha KostyaSha merged commit 57e76cb into jenkinsci:master May 13, 2024
@amuniz
Copy link
Member Author

amuniz commented May 14, 2024

@KostyaSha if you can cut a release anytime soon, that would be nice. Thanks.

@viceice
Copy link
Member

viceice commented May 17, 2024

@KostyaSha The GitHub releases are not published since v1.36.1

@jenkinsci jenkinsci deleted a comment from 369tux May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants