Register XStream alias even earlier#304
Merged
KostyaSha merged 2 commits intojenkinsci:masterfrom Oct 19, 2022
Merged
Conversation
jtnord
reviewed
Oct 18, 2022
car-roll
approved these changes
Oct 18, 2022
Contributor
|
Apparently this causes some initialization issue https://issues.jenkins.io/browse/JENKINS-70351. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a change in the git plugin that somehow makes
GitHubPluginConfigload earlier thanGitHubPlugin.start()So when running the
MigratorTestwith git plugin 4.12.1 installed (for example during PCT) it fails because the old configuration could not be loaded.The fix is simply to register the XStream alias before
InitMilestone.SYSTEM_CONFIG_LOADEDinstead ofGitHubPlugin.start().I've verified that it works by temporarily adding the git plugin as a test dependency in the pom of this plugin, and the
MigratorTestfails before this change and succeeds after the fix got applied.