Require Jenkins 2.204.1 or later#532
Merged
MarkEWaite merged 7 commits intojenkinsci:masterfrom Apr 2, 2020
Merged
Conversation
fcojfernandez
approved these changes
Apr 1, 2020
Member
fcojfernandez
left a comment
There was a problem hiding this comment.
Change looks good. I've left a question just to get a better insight about how the plugin is built. thanks in avance!
Less pressure on ci.jenkins.io
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Jenkins 2.204.1 or later
This pull request switches from requiring Jenkins 2.138.4 as minimum version to require Jenkins 2.204.1 as minimum version. Using a modern version like 2.204.1 includes the trilead-api separation from the Jenkins core and simplifies testing.
Checklist
Types of changes
Further comments
User based justification for choosing 2.204.1 as the new minimum version:
Users that are choosing to stay current with the git client plugin are also choosing to stay current with Jenkins releases. That's a very good thing. Special thanks to the users for choosing to update to recent releases!
The Jenkinsfile is now configured to test Jenkins 2.204.6 on Windows with Java 8 and Jenkins 2.222.1 or 2.204.6 on Linux with both Java 8 and Java 11. It intentionally tests the most recent release of Jenkins 2.204.x while only requiring 2.204.1 so that users of 2.204.2 are not forced to update to use the git client plugin.
There are still some spotbugs warnings that will either need to be suppressed, resolved, or hidden by restoring the spotbugs settings that were used until the recent update to spotbugs 4.0.1. Specifically, the spotbugs threshold was previously set to 'High' with the effort set to 'Low'. The new settings invert that and set the threshold to 'Low' and the effort to 'Max'.
This change intentionally uses plugin pom 4.0-beta with the assumption that plugin pom 4.0 will be released within the next month or so. If it is not released in that time, then the most recent released parent will be used instead.
Marching pull request for git plugin at jenkinsci/git-plugin#862