Merged
Conversation
jtnord
reviewed
Feb 25, 2025
.../org/jenkinsci/plugins/docker/workflow/declarative/DockerPipelineFromDockerfileScript.groovy
Show resolved
Hide resolved
jtnord
reviewed
Feb 25, 2025
.../org/jenkinsci/plugins/docker/workflow/declarative/DockerPipelineFromDockerfileScript.groovy
Outdated
Show resolved
Hide resolved
jtnord
approved these changes
Feb 25, 2025
Member
jtnord
left a comment
There was a problem hiding this comment.
looks reasonable as far as I understand it
dwnusbaum
approved these changes
Feb 25, 2025
jglick
commented
Feb 25, 2025
| } else { | ||
| runImage(body).call() | ||
| protected void configureRegistry(Closure body) { | ||
| DeclarativeDockerUtils.DockerRegistry registry = DeclarativeDockerUtils.DockerRegistry.build(describable.registryUrl, describable.registryCredentialsId) |
lnlrbr
pushed a commit
to lnlrbr/docker-workflow-plugin
that referenced
this pull request
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts to jenkinsci/pipeline-model-definition-plugin#762, which is unfortunately incompatible in that
DeclarativeDockerUtils.getLabelScriptis going to return a new type of object. (Due to the complex mixture of CPS-transformed Groovy sources and Java APIs, it did not seem feasible to make that a compatible change.)