[JENKINS-56674] Masking of environment variables passed to docker exec#167
Merged
dwnusbaum merged 6 commits intojenkinsci:masterfrom Mar 29, 2019
Merged
Conversation
…nside docker image run
…ocker-workflow-plugin into envMasking-JENKINS-56674
Wadeck
approved these changes
Mar 29, 2019
Wadeck
left a comment
There was a problem hiding this comment.
Not tested deeply but nothing seems wrong.
🐝
dwnusbaum
approved these changes
Mar 29, 2019
Contributor
|
Great, I'm glad that my findings really helps make this plugin better ) |
Member
Author
|
It is not currently released. |
|
When we will be able to install this update and which version it is planned to be released in? |
Member
Author
|
@Dmitry1987 as you can see in JIRA, it has been released as 1.18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-56674 Subsumes #166 by @vkravets.
I consider this a security hardening. Suppose you have some plugin which uses
Launcher, callsenvon a sensitive variable, and does not use.quiet(true). Normally it will look like this in the log:If you wrapped in
withDockerContainerbefore this fix:and after:
Or for old versions of Docker,
vs.