Merged
Conversation
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin Co-authored-by: Moderne <team@moderne.io>
NotMyFault
approved these changes
Aug 30, 2023
Member
NotMyFault
left a comment
There was a problem hiding this comment.
@jenkinsci/disk-usage-plugin-developers any chance this could be merged? That would facilitate testing the plugin on Java 21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR aims to modernize the parent pom and fix the SpotBugs issues raised by the newer tooling. In some cases I suppressed the SpotBugs warnings. Ideally they'd be fixed, but I didn't want to make this change too big.
This was generated by the ModernizePlugin recipe on moderne.io and manually touched up.
Testing done
Ran
mvn clean verifylocally.