Skip to content

update styling#88

Merged
froque merged 2 commits intojenkinsci:masterfrom
mawinter69:styling
Jul 3, 2023
Merged

update styling#88
froque merged 2 commits intojenkinsci:masterfrom
mawinter69:styling

Conversation

@mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jun 29, 2023

  • on the configure page where some old unstyled inputs and selects. Those are now jenkins styled.
    Units are shown
  • on the disk-usage overview page, the filter form is now styled like Jenkins forms with a correspondingly styled button
  • made the svg a symbol (requires Jenkins 2.401.1 as previous lts versions filter out the ids and thus break the svg)
  • removed the sidepanel as it contained only a link back to dashboard which is not recommended (see https://weekly.ci.jenkins.io/design-library/Layouts/)
  • added a breadcrumb title so we see where we are
  • use the bom to get rid of specifying version for some of the dependencies
  • use Jenkins 2.401.1

Before:
image
image
image

After:
image
image
image

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

- on the configure page where some old unstyled inputs and selects.
  Those are now jenkins styled

- on the disk-usage overview page, the filter form is now styled like
  Jenkins forms with a corerspondingly styled button

- made the svg a symbol (requires Jenkins 2.401.1 as previous lts
  versions filter out the ids and thus break the svg)
potentially newer matrix requires an update of the fileList files
@mawinter69 mawinter69 marked this pull request as ready for review June 29, 2023 14:48
@froque
Copy link
Member

froque commented Jul 3, 2023

nice, thanks

@froque froque merged commit eea7f24 into jenkinsci:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants