Migrate tests to JUnit Jupiter#389
Merged
jglick merged 1 commit intojenkinsci:masterfrom Nov 5, 2025
strangelookingnerd:migrate_to_jupiter
Merged
Migrate tests to JUnit Jupiter#389jglick merged 1 commit intojenkinsci:masterfrom strangelookingnerd:migrate_to_jupiter
jglick merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:migrate_to_jupiter
Conversation
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup * Ban JUnit4 imports
jglick
approved these changes
Nov 5, 2025
Comment on lines
+227
to
+231
| """ | ||
| sh ''' | ||
| cat "$THEKEY" > key.txt\ | ||
| ''' | ||
| """; |
Member
There was a problem hiding this comment.
Stuff like this is obviously a mess, but would need to be fixed up more manually by a human looking at the test case and formatting it nicely. I would prefer it if you would not try to convert multiline strings to text blocks as part of PRs like this. It has nothing to do with JUnit 5 and just makes it that much harder to review, and often makes the code less legible.
Comment on lines
-52
to
+68
| @Rule public FlagRule<Boolean> useWatching = new FlagRule<>(() -> DurableTaskStep.USE_WATCHING, v -> DurableTaskStep.USE_WATCHING = v); | ||
| @AfterEach | ||
| void afterEach() { | ||
| DurableTaskStep.USE_WATCHING = useWatching; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit Jupiter. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Submitter checklist