[JENKINS-75914] Do not mask empty secrets#378
Merged
jtnord merged 1 commit intojenkinsci:masterfrom Jul 22, 2025
Merged
Conversation
6 tasks
jtnord
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[JENKINS-75914] Do not mask empty secrets
Supersedes #377.
The issue encountered in JENKINS-75914 is due to the lack of handling for empty credentials.
A check is performed for normal messages on the console log
credentials-binding-plugin/src/main/java/org/jenkinsci/plugins/credentialsbinding/masking/SecretPatterns.java
Line 102 in baac667
I'm adding this check before changing the type of exception, to avoid throwing a
MaskedExceptionwhen there's nothing to mask.Testing done
I tested this change locally using the example provided in JENKINS-75914 and added a test to cover this case. The test fails without this change.
Submitter checklist