Remove missed occurence of FileOnMasterKeyStoreSource#312
Merged
jtnord merged 1 commit intojenkinsci:masterfrom Jul 3, 2024
Merged
Remove missed occurence of FileOnMasterKeyStoreSource#312jtnord merged 1 commit intojenkinsci:masterfrom
jtnord merged 1 commit intojenkinsci:masterfrom
Conversation
jtnord
commented
Jul 3, 2024
| String password = "android"; | ||
| StandardCertificateCredentials c = new CertificateCredentialsImpl(CredentialsScope.GLOBAL, "my-certificate", alias, | ||
| password, new CertificateCredentialsImpl.FileOnMasterKeyStoreSource(certificate.getAbsolutePath())); | ||
| password, new CertificateCredentialsImpl.UploadedKeyStoreSource(new FileParameterValue.FileItemImpl(certificate), null)); |
jtnord
commented
Jul 3, 2024
| // create the Pipeline job | ||
| WorkflowJob p = r.jenkins.createProject(WorkflowJob.class, "p"); | ||
| String pipelineScript = IOUtils.toString(getTestResourceInputStream("basicsPipeline-Jenkinsfile"), StandardCharsets.UTF_8); | ||
| String pipelineScript = getTestResourceAsUTF8String("basicsPipeline-Jenkinsfile"); |
Member
Author
There was a problem hiding this comment.
preventing resource leaks by ensuring the stream is closed.
jtnord
commented
Jul 3, 2024
| f.copyFrom(in); | ||
| f.chmod(mask); | ||
| return f; | ||
| try (InputStream in = getTestResourceInputStream(fileName)) { |
Member
Author
There was a problem hiding this comment.
preventing resource leaks by ensuring the stream is closed.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to jenkinsci/credentials-plugin#540
ammends #310
Testing done
ran
mvn verifywith the following changeSubmitter checklist