Suppress warnings for spotbugs 4.8.3#286
Merged
jglick merged 3 commits intojenkinsci:masterfrom Jan 16, 2024
Merged
Conversation
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77) Plugin pom 4.77 needs this change to resolve new spotbugs warnings that will be reported by spotbugs 4.8.3 and later. Can skip the changelog, since this is not visible to users. Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible. Confirmed that spotbugs is silent with plugin pom 4.77 after this change.
Contributor
Author
|
CI failure is due to a performance issue / timeout that the infrastructure team is investigating. Refer to: |
jglick
reviewed
Jan 16, 2024
Member
jglick
left a comment
There was a problem hiding this comment.
and actually switch to new parent
src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77 describes the changes in the 4.77 release of the parent pom. Those changes include: * jenkinsci/plugin-pom#880 - test harness update * jenkinsci/plugin-pom#884 - spotbugs plugin update Other dependencies were also updaetd in that parent pom.
Contributor
Author
Done in 00ecfef |
jglick
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress warnings for spotbugs 4.8.3
Plugin pom 4.77 needs this change to resolve new spotbugs warnings that will be reported by spotbugs 4.8.3 and later.
Can skip the changelog, since this is not visible to users.
Testing done
Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.
Confirmed that spotbugs is silent with plugin pom 4.77 after this change.