Download and include images in posterous migrator.#4
Download and include images in posterous migrator.#4parkr wants to merge 1 commit intoinitial-migrator-importfrom
Conversation
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
|
Having some way to turn this off when you call the importer would be way cool. |
|
Hey, thanks for taking a look at this. Like I said, it was just to get the ball rolling as much as anything else. What do you think the best interface for disabling it would be? And opt-in or opt-out I suppose is the other question; maybe opt-in is preferable, since it will take more time and bandwidth. Perhaps a flag --include-images? I think my posterous account is still active if you'd like me to play with it. |
|
Hey! Thanks for getting back to me so quickly. I think the best interface would be to pass in an options has or something into the migrator that sets |
|
By default, though, I don't think I would want to download all those images. |
|
Sorry for the delay in getting back to you -- had to wait for the weekend :) Thanks for the "keyword args" tip, like I said I haven't really done any ruby. That looks much nicer though. I've implemented that functionality anyway, and it works fine on my old account. Do you want me to issue another pull request? I've pushed the changes to my fork, although I haven't rebased against the current state of affairs. Thanks for your work on this, it'll be good to see jekyll getting some love again! |
|
If you have any improvements that you think should be included, maybe you can submit a pull-request against this branch? Then I can check those and merge them into this branch, then merge this branch into our project :) |
|
Huh, newbie question -- I was working against the entire mojombo/jekyll, not this extraction. Do you know if there's an easy way to pull my commits + history onto a clone of just jekyll-import? Short of using git-subtree, I suppose? Maybe it's easiest just via a single patch, since it's not exactly a big change :) |
|
Merged. |
ACHTUNG!! This is being merged into a non-master branch.
In jekyll/jekyll#509, @markhepburn suggested that we import images from Posterous, and supplied the code. Thought it was a cool idea.
I haven't tested this (hadn't heard of Posterous before a couple weeks ago) but I think it worked for Mark.
Here's his original message: