For MT: :entry_text_more attribute is nil or not before evaluate#45
Merged
mattr- merged 1 commit intojekyll:masterfrom Aug 9, 2013
Merged
Conversation
Member
|
Oh great, thanks! LGTM. @mattr-? |
Member
|
for a quick fix, this is fine. If you wanted to take this a step further, you could wrap the conditional in a method to improve the clarity of the code. def extra_entry_text_empty?(post)
post[:entry_text_more].nil? || post[:entry_text_more].strip.empty?
endand replace the condition like so: if extra_entry_text_empty?(post)
...
end |
Contributor
Author
|
I like that modification better, but only if you want to cost lines+methods for clarity. (besides the commit message's clarity). will change and push again later. |
Contributor
Author
|
Updated. |
Member
|
I will always take clearer code over code that is less lines. Thanks for updating this! 😃 |
Contributor
Author
|
no problem. Looks like travis said OK. |
Member
|
Boom! LGTM. |
mattr-
added a commit
that referenced
this pull request
Aug 9, 2013
For MT: :entry_text_more attribute is nil or not before evaluate
mattr-
added a commit
that referenced
this pull request
Aug 9, 2013
Contributor
Author
|
tnx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happen when I tried my MovableType blog import (still on going)