Added initial version of a test case for Tumblr#43
Merged
parkr merged 1 commit intojekyll:masterfrom Jul 25, 2013
Merged
Conversation
Member
|
🆒 This is a great start! @parkr what do you think? |
Member
|
LGTM! How about we merge and refactor in a different PR? |
Contributor
Author
|
Sounds good to me guys. I will keep working on this branch and will open new PRs. |
parkr
added a commit
that referenced
this pull request
Jul 25, 2013
Added initial version of a test case for Tumblr
parkr
added a commit
that referenced
this pull request
Jul 26, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found tumblr.rb not an easy module to test. I have started with the most simple data check from a mocked JSON payload and was able to cover the basics of JekyllImport::Tumblr.post_to_hash. I can go just a little bit further without refactoring the module, so I thought I should start a pull request to gather feedbacks.
Oh, and I had to bump rake version up because I was hitting the issue mentioned here.