Skip to content

Use mysql by default in Drupal importers.#347

Merged
jekyllbot merged 1 commit intojekyll:masterfrom
argilo:drupal-engine-default
Mar 2, 2018
Merged

Use mysql by default in Drupal importers.#347
jekyllbot merged 1 commit intojekyll:masterfrom
argilo:drupal-engine-default

Conversation

@argilo
Copy link
Contributor

@argilo argilo commented Mar 1, 2018

#331 added support for PostgreSQL in the Drupal importers. According to the documentation, MySQL is supposed to be the default engine, but the engine parameter is now mandatory because the default value is not used. This PR fixes that by using the value that was added to the DEFAULTS hash.

/cc @kesara

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pathawks
Copy link
Member

pathawks commented Mar 2, 2018

@jekyllbot: 🚢 +bug

@jekyllbot jekyllbot merged commit a48f415 into jekyll:master Mar 2, 2018
jekyllbot added a commit that referenced this pull request Mar 2, 2018
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants