Skip to content

Add forced utf8 encoding of titles#22

Merged
parkr merged 1 commit intojekyll:masterfrom
chrisivens:fix-drupal6-titles
Jun 30, 2013
Merged

Add forced utf8 encoding of titles#22
parkr merged 1 commit intojekyll:masterfrom
chrisivens:fix-drupal6-titles

Conversation

@chrisivens
Copy link
Contributor

Prevents yaml from binary encoding the title

Prevents yaml from binary encoding the title
@parkr
Copy link
Member

parkr commented May 11, 2013

I don't think 1.8.7 strings contain #force_encoding. Could you write a test for this?

@steko
Copy link

steko commented Jun 5, 2013

FWIW I can confirm that I have this issue with Ruby 1.9.3 and the proposed patch fixes the problem.

@parkr
Copy link
Member

parkr commented Jun 6, 2013

Shouldn't we encode() as utf-8 instead of force encode?

parkr added a commit that referenced this pull request Jun 30, 2013
Add forced utf8 encoding of titles
@parkr parkr merged commit 2e1354f into jekyll:master Jun 30, 2013
parkr added a commit that referenced this pull request Jun 30, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants