Using the old mysql driver results in broken YAML frontmatters#20
Closed
x3ro wants to merge 1 commit intojekyll:masterfrom
x3ro:fix-binary-encoding-in-wordpress-yaml
Closed
Using the old mysql driver results in broken YAML frontmatters#20x3ro wants to merge 1 commit intojekyll:masterfrom x3ro:fix-binary-encoding-in-wordpress-yaml
x3ro wants to merge 1 commit intojekyll:masterfrom
x3ro:fix-binary-encoding-in-wordpress-yaml
Conversation
When using the old mysql driver, the returned string data always seems to have a ASCII-8BIT encoding. `to_yaml` however expects all strings to be UTF-8, and if they are not encodes them as they were binary, which in turn breaks the Jekyll site generation (breaks in the sense that category names are all garbled, for example) Reference for the mysql driver behaviour: http://stackoverflow.com/q/14070281/124257
Member
|
Weird test failure due to 1.8.7 can't find |
Contributor
Author
|
Seems to be happening in #15 too, though. I'm fairly certain that I didn't cause the issue. I'll install a 1.8.7 to see if I can reproduce it though. |
Member
|
Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the old mysql driver, the returned string data always
seems to have a ASCII-8BIT encoding.
to_yamlhowever expects allstrings to be UTF-8, and if they are not, encodes them as if they were
binary, which in turn breaks the Jekyll site generation (breaks in the
sense that category names are all garbled, for example)
Reference for the mysql driver behaviour:
http://stackoverflow.com/q/14070281/124257