Add Blogger (blogspot.com) importer#162
Merged
parkr merged 16 commits intojekyll:masterfrom Sep 19, 2014
cat-in-136:spike-blogger-support
Merged
Add Blogger (blogspot.com) importer#162parkr merged 16 commits intojekyll:masterfrom cat-in-136:spike-blogger-support
parkr merged 16 commits intojekyll:masterfrom
cat-in-136:spike-blogger-support
Conversation
…replace-internal-link
…blogger-info and --replace-internal-link
…mport blogger
Usage:
jekyll import blogger [options]
Options:
--source NAME The XML file (blog-MM-DD-YYYY.xml) path to import
--no-blogger-info Leave blogger-URL info (id and old URL.) as YAML data (default: false)
--replace-internal-link Whether to replace internal links with the post_url liquid codes (default: false)
-h, --help Show this message
-v, --version Print the name and version
-t, --trace Show the full backtrace when an error occurs
Member
There was a problem hiding this comment.
This needs to be placed in require_deps.
Contributor
Author
There was a problem hiding this comment.
Removing the line cause an error on include REXML::StreamListener on BloggerAtomStreamListener class.
I have no idea how to do same without require...
Member
|
Looks great! I'd gladly merge if you address my 2 comments and fix the tests, please. Thanks! |
Two 'the in-elem-entry-to-post-data converter should raise an error if original_url not exists.' exists (duplicated). So the 2nd test is replaced with '...should raise an error if non-post-kind not exists'. In addition, fix the 1st test.
…e `require_deps` instead of `require`
Contributor
Author
|
I wonder if the changeset cd3980a is OK wrt coding rule... |
parkr
added a commit
that referenced
this pull request
Sep 19, 2014
Member
|
It is perfect! Just so you know, I'll be coming back to you if people come asking about this code 😄 Thanks so much for your contribution!! |
parkr
added a commit
that referenced
this pull request
Sep 19, 2014
parkr
added a commit
that referenced
this pull request
Sep 19, 2014
parkr
added a commit
that referenced
this pull request
Sep 19, 2014
parkr
added a commit
that referenced
this pull request
Apr 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a Blogger-to-Jekyll importer.
Would you capture my importer?