Conversation
lib/jekyll-import/importers/ghost.rb
Outdated
There was a problem hiding this comment.
Can you please add a not to 'Database file' that it defaults to ./ghost.db?
|
Looks awesome!! Thanks so much for writing this :) Would you please split the |
|
@parkr Sure. I just realized that the ghost importer even imports the drafts, but doesn't move it to the _drafts directory, so I am currently working on that. |
|
@gr4y you rock. thanks! |
|
@parkr There we go. The importer now copies drafts to the |
|
It doesn't need to be mandatory if you're ok with having a default. :) |
lib/jekyll-import/importers/ghost.rb
Outdated
There was a problem hiding this comment.
This is a very interesting way to approach this. What's your primary dev language? Looks very Python/C :)
What do you think of the following?
filename = File.join(directory, "#{date.strftime('%Y-%m-%d')}-#{post[:slug]}.markdown")It's a bit more idiomatic to Ruby (but that doesn't mean we have to do it that way)
There was a problem hiding this comment.
I copied that line from the Joomla Importer, but I think you are right. The File.join approach is a little more descriptive and easier to read. I updated my branch.
I would consider Ruby as my primary language, cause I write most of my stuff in Ruby, but I am also writing Java and PHP when I have to.
|
Looking really great so far! |
|
👍 so far. Really excited about this. 😃 @gr4y Should we consider this complete now? |
|
Looks so good. Would you please add tests? Once those are in place, I'll merge :) |
There was a problem hiding this comment.
No one will see this note -- remove it? 😄
Hey there,
I quickly hacked together an Importer for the Ghost SQLite Database. 😄