Closed
Conversation
captures are static so we can't use one here otherwise the last page to include the file is what wins due to the way include caching works during generation.
|
When I apply this PR, the docs still show "Deployment" for all the headers |
|
If I completely revert this commit it fixes this issue. I've added a comment there. |
Contributor
Agree. If I manually remove |
Member
Author
|
The fact that it's broken is why it's still a draft PR 😄 There's a better fix available now though so I'll close this one out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Captures are static so we can't use one here otherwise the last page to
include the file is what wins due to the way include caching works
during generation.
Context
Closes #9527