Improve network error detection and reduced retry delay #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Jellyfin server is fully offline, an Axios error won't be returned, so
isNetworkError()will always be false. I moved the string checks to run even if the error isn't an Axios error.This isn't really that good of a fix, to be honest if the error isn't an Axios error it probably is a connection error.
I also reduced the amount of retries and the time between said retries, since it slows down the interface quite a bit.
Ideally this should be merged alongside #1435, since a network error redirects to that route, which doesn't have translation strings at the moment, and isn't that usable.
Fixes #1433