Skip to content

Conversation

@ItzELECTR0
Copy link
Contributor

@ItzELECTR0 ItzELECTR0 commented Dec 21, 2025

Added a version check for Jellyfin servers 10.11+ to use the new "ApiKey" syntax.
Also added a API_KEY_CAMELCASE feature flag for this case.

Marked as draft because I've only tested it on my machine with my server.

@vercel
Copy link

vercel bot commented Dec 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
feishin Ready Ready Preview, Comment Dec 23, 2025 3:46am

@jeffvli
Copy link
Owner

jeffvli commented Dec 21, 2025

This will definitely need additional consideration, because I'm on the latest stable 10.11.5, and the api_key parameter is still valid.

Renaming api_key to ApiKey would be a breaking change from Jellyfin's API so I'm not sure why they would do that in a minor version bump.

I'll leave this PR up, but let's wait to see if this change makes it into Jellyfin's stable releases first.

@ItzELECTR0
Copy link
Contributor Author

It is REALLY strange. I'm going to try and test some more things and see if I can find anything.

@salguerooo
Copy link
Contributor

So I was taking a look at the jellyfin versions and looks like api_key has been deprecated for a while and the preferred way is ApiKey. Maybe on 10.12 they will drop it for good?

Some links for reference:
jellyfin/jellyfin#15559
jellyfin/jellyfin#13306
https://gist.github.com/nielsvanvelzen/ea047d9028f676185832e51ffaf12a6f

@ItzELECTR0
Copy link
Contributor Author

I downgraded my server from 10.12 to 10.11.5 and yeah that does still use api_key so I have virtually no clue why it didn't work without this patch. Strangely enough, it does work. I also tried copying the Streaming URL and replaced api_key with ApiKey and it worked, which probably means they're in some sort of transition phase? I have no idea what's going on or why it works this way but 10.11.5 can take both. I then went back to 10.12 to try the reverse (replace ApiKey with api_key) but that did not work. So 10.12 can only take ApiKey which is very bizarre.

@ItzELECTR0
Copy link
Contributor Author

So I was taking a look at the jellyfin versions and looks like api_key has been deprecated for a while and the preferred way is ApiKey. Maybe on 10.12 they will drop it for good?

Some links for reference: jellyfin/jellyfin#15559 jellyfin/jellyfin#13306 gist.github.com/nielsvanvelzen/ea047d9028f676185832e51ffaf12a6f

This popped up just as I finished typing. Wow.

@ItzELECTR0 ItzELECTR0 marked this pull request as ready for review December 21, 2025 23:05
@jeffvli
Copy link
Owner

jeffvli commented Dec 21, 2025

Good find.

For this PR, you should pin the version for the feature to be 10.12.0 instead.

@ItzELECTR0
Copy link
Contributor Author

Fair enough.

Change 10.11 version check to 10.12
@ItzELECTR0 ItzELECTR0 changed the title Fix API parameter for Jellyfin 10.11 and up Fix API parameter for Jellyfin 10.12 and up Dec 21, 2025
@jeffvli
Copy link
Owner

jeffvli commented Dec 23, 2025

I decided to simplify the approach here to just force the new ApiKey parameter, as the legacy one has been deprecated for some time now.

@jeffvli jeffvli merged commit f418bbf into jeffvli:development Dec 23, 2025
6 checks passed
@ItzELECTR0 ItzELECTR0 deleted the patch-1 branch December 23, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants