You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the 'preservePitch' setting to the "dropdown" (dropup). I've found myself (as well as a few other friends who use Feishin) wanting a toggle for this quickly accessible in the dropup menu, so I thought I would PR it.
This only shows when the web player is selected. It does not show for the Mpv player.
I'm not sure the way I'm doing this is up to par with what standards are being used in this codebase. I could abstract the settings part and make it similar to useSetCurrentSpeed?
i'm not a collaborator/reviewer, but i think this option should only be shown if using web player
Preserve pitch words both for the webplayer and the mpv player, assuming you're thinking preserve pitch only works for the web player.
I'm sure it's possible to add it for MPV, but the option was only implemented for web and is hidden from settings when MPV is chosen (I implemented this feature originally)
i'm not a collaborator/reviewer, but i think this option should only be shown if using web player
Preserve pitch words both for the webplayer and the mpv player, assuming you're thinking preserve pitch only works for the web player.
I'm sure it's possible to add it for MPV, but the option was only implemented for web and is hidden from settings when MPV is chosen (I implemented this feature originally)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tbh idk what that toggle means exactly but it isn't mpv
This PR adds the 'preservePitch' setting to the "dropdown" (dropup). I've found myself (as well as a few other friends who use Feishin) wanting a toggle for this quickly accessible in the dropup menu, so I thought I would PR it.
This only shows when the web player is selected. It does not show for the Mpv player.
I'm not sure the way I'm doing this is up to par with what standards are being used in this codebase. I could abstract the settings part and make it similar to
useSetCurrentSpeed?