Prevent Media Session Handling on MPV #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jeffvli
reviewed
Oct 29, 2025
Comment on lines
53
to
55
| isHidden: | ||
| !isElectron() || | ||
| (enableWindowsMediaSession && isWindows && playbackType === PlaybackType.WEB), |
Owner
There was a problem hiding this comment.
Personally not in favor of hiding it.
Users who are already using MPV may never know that this option is available if it is hidden. Disabling is enough.
Contributor
Author
There was a problem hiding this comment.
Then should we change the globalMediaHotkeys too, only disable but not hidden for Web users?
Contributor
There was a problem hiding this comment.
Maybe I'm slow but why would MPV users need to see/know about this option when they are already getting the same functionality anyway? They're not missing out on anything not seeing it 🤔
Or am I misunderstanding the PR description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPV have its own integration of SMTC, and hence currently behavior of feishin is that the media session option would do nothing additive but disables global hotkeys for MPV.
In according to:
This PR does the following: