Skip to content

Conversation

@ENDlezZenith
Copy link
Contributor

Currently, lyric translation would not reset and would directly pass the translation of the last song to the next.

This PR does the following:

  • Clear the lyric translation cache and disable it when changing tracks
  • Added a toggle (users who would not like translation to be enabled automatically could still use the translation button that is only temporary for the current track playing) for auto translation, so users no longer need to click translation every time a new track is playing (same behavior as fetch lyric from internet source)
  • Trivial lyric translation logic fix and reuse code for fetching lyric translation api responses

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
feishin Ready Ready Preview Comment Oct 29, 2025 4:54am

	modified:   src/i18n/locales/en.json
Refactor lyrics translation logic and improve handling of selected lyrics index.
	modified:   src/renderer/store/settings.store.ts
@jeffvli jeffvli merged commit dd34888 into jeffvli:development Nov 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants