Feature: Add song and artist links to discord RPC #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kgarner7
requested changes
Sep 30, 2025
Collaborator
kgarner7
left a comment
There was a problem hiding this comment.
- If there are MBIDs (album, song, track), and the user has enabled MBZ, those are more accurate
- Which links (if any) should be controlled by show last.fm / show musicbrainz links
Contributor
Author
I've gone with only providing musicbrainz links to songs, using the track id over recording id where possible as it links more specifically to the album the song is being played from
|
kgarner7
requested changes
Oct 3, 2025
Collaborator
kgarner7
left a comment
There was a problem hiding this comment.
Thanks for the additional work! Please see recommended changes.
kgarner7
reviewed
Oct 3, 2025
Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
|
@VulpesNova is attempting to deploy a commit to the jeffvli's projects Team on Vercel. A member of the Team first needs to authorize it. |
1 task
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added song and artist links to discord RPC as mentioned in #1155. If the artist is empty it will skip links, if the album is empty it will be replaced with an underscore in the song link.