Skip to content

Add autodiscovery for Jellyfin servers #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgarner7 merged 4 commits into from
Sep 26, 2025
Merged

Add autodiscovery for Jellyfin servers #1146

kgarner7 merged 4 commits into from
Sep 26, 2025

Conversation

@hedgehog1029
Copy link
Contributor

@hedgehog1029 hedgehog1029 commented Sep 23, 2025

I was disappointed that Feishin didn't auto-detect my jellyfin server on launch, so I implemented it :3

  • Autodiscovery fires automatically and results are streamed back to the UI as they arrive
  • Only implemented for Jellyfin, but space left in the implementation if the other servers secretly have autodiscovery methods too (I couldn't find any from a cursory look)
  • Click a result to autofill the name and URL into the setup form
  • UI could maybe do with a touch up

@vercel
Copy link

vercel bot commented Sep 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
feishin Ready Ready Preview Comment Sep 26, 2025 9:21pm

kgarner7
kgarner7 requested changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@kgarner7 kgarner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Multiple linter errors are present. Run pnpm lint:fix, and ignore the warning in context-menu-provider.tsx
  2. This does not appear to work if Jellyfin is on the same system as Feishin (and also if there are VPNs/alternative routing)

@hedgehog1029
Copy link
Contributor Author

hedgehog1029 commented Sep 26, 2025

Linter errors resolved 🫡

I think it not working for local machine or weird routing setups is normal and in-line with how official Jellyfin clients would expect to work. Discovery works by broadcasting a UDP packet to 255.255.255.255:7359, and packets with that destination address are never routed, only switched. So you have to be on the same L2 broadcast domain.

Also, all-high-bits broadcast is kind of weird and if you have multiple suitable interfaces it might just pick a random interface each time to send the packet out of. We could do slightly better if we scanned all the interfaces and used the subnet broadcast address to send a packet out of each interface, but that sounds complicated and platform-specific so I didn't bother.

@hedgehog1029
Copy link
Contributor Author

hedgehog1029 commented Sep 26, 2025

Per some discussion in the discord, fixed localhost discovery by sending another discovery packet to the loopback broadcast address!

@kgarner7 kgarner7 requested a review from jeffvli September 26, 2025 21:23
@kgarner7 kgarner7 merged commit e344adf into jeffvli:development Sep 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgarner7 kgarner7 kgarner7 approved these changes

@jeffvli jeffvli Awaiting requested review from jeffvli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hedgehog1029 @kgarner7