feat: add semantic selectors for now-playing media #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds unique class names to the elements that display the currently playing media information. This makes it easier for extension developers to parse the DOM and understand what media is playing. The following classes have been added: - `media-player`: The main player container. - `player-cover-art`: The cover art of the playing track. - `song-title`: The title of the playing track. - `song-artist`: The artist of the playing track. - `song-album`: The album of the playing track. - `player-state-playing`/`player-state-paused`: The state of the player. - `elapsed-time`: The elapsed time of the playing track. - `total-duration`: The total duration of the playing track.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 19, 2025
Owner
|
I'm not opposed to this, but adding plain classes is a bit prone to breakage if these components ever get refactored. At the very least I would say add them to an enum with comments on how they're being used, and then reference them in the components. |
Contributor
Author
|
Thanks for the feedback . I moved the selectors to consts and added a node. Would there be anything else I should change? |
jeffvli
reviewed
Sep 21, 2025
jeffvli
reviewed
Sep 21, 2025
jeffvli
reviewed
Sep 21, 2025
jeffvli
reviewed
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds unique class names to the elements that display the currently playing media information. This makes it easier for extension developers to parse the DOM and understand what media is playing.
It'll allow us to do things like web-scrobbler/web-scrobbler#5612 easier since elements will be semantically available.
The following classes have been added:
media-player: The main player container.player-cover-art: The cover art of the playing track.song-title: The title of the playing track.song-artist: The artist of the playing track.song-album: The album of the playing track.player-state-playing/player-state-paused: The state of the player.elapsed-time: The elapsed time of the playing track.total-duration: The total duration of the playing track.I did test the changes locally against the extension using the tags and it did work. However not sure if what was changed is inline with how it should be structured.